True vs mc

[mcolomermolla]

• Corrections and changes made in pull request #31 incorporated
• New module for time uncertainty computation, instead of doing it inside TimeDistDiff

[tsengj10]

Thanks for this @mcolomermolla. I suppose one can make this more generic by not requiring a particular pair of detectors?

The code may also be simpler using the alert() method, rather than update().

While looking through this, it occurred to me another (possibly clearer and more re-usable) arrangement could be as follows:

1. JUNO
2. IceCube
3. TimeDistDiff, observing JUNO and IceCube
4. a true time diff module (which just takes the diff between the true times in the payloads), also observing JUNO and IceCube
5. a comparison module which takes the difference between the dt's calculated in (3) and (4)

In order to keep the order of subtraction the same (i.e., JUNO - IceCube, or vice versa?), you can call Node.last_watch_index(), which gives you the index of the upstream node. If you observe with ["IceCube","JUNO"], then an IceCube payload will come with an index 0, and JUNO with an index 1.

(By the way, I asked Sihan, one of our new students, to look at calculating the true times - relative to the neutrino wavefront passing the center of the Earth, or something like that - for each detector given a distant supernova in some given direction. Do you already have code for something like this, for example, for use in TG3?)

[mcolomermolla]

Yes, in principle we could generically call det1 and det2. Then, the point is that the two detectors (e.g. JUNO and IceCube) when called in the csv file, take from this config file the .txt (with the provided time profile from each detector). Where/how would be the best way to retrieve these data from the experiments?

For the steps, I fully agree, and it is actually the case how it is now. Just: i) After 1) and 2) there is the Combine.py which enters ii) I don't think 4) and 5) need to be separate modules, this will delay the chain, it can be done in the same one as now in True_VS_mc

Yes, this is in the code I sended you yesterday by email ! He can start having a look at it

[mcolomermolla]

I have taken into account all your comments in the new commits I pushed today. Let me know if you have any additional comments or suggestions, and please feel free to modify whatever you consider convenient.

[tsengj10]

Thanks. Let's go with this and evolve it along with all the other code.

[tsengj10]

@mcolomermolla please check that I resolved the merge conflict correctly. Thanks.

[mcolomermolla]

@mcolomermolla please check that I resolved the merge conflict correctly. Thanks.

How can I see which the conflict was? In principle everything seems ok to me however.

[tsengj10]

Just click on the last commit.

[mcolomermolla]

OK, yes, that's fine! (I though this change in TimeDistDiff was already in the master, strange)