search

SNEWS2 / snewpdag

SNEWS2 alert calculations
BSD 3-Clause "New" or "Revised" License
1 stars 13 forks source link

Fixed bug in Chi2Calculator pull request #56

Closed dallaval5u closed 2 years ago

dallaval5u commented 2 years ago

Fixed bugs in Chi2Calculator (was not working for 2 detectors) and TimeSeries.py (was working only if data['gen'] was not present.

tsengj10 commented 2 years ago

Can you make sure TimeSeries still works for the test-csv, test-nth, test-gen-config, and test-liq-config configurations in snewpdag/data? One uses the trial or trial2 pattern in the Makefile, replacing the configuration files.

I'm not entirely sure what happened to the history such that you have a conflict in TimeSeries. Perhaps it was the merge from origin/master before your subsequent development?

It may help in later development to develop in branches from your fork, rather than working in your own master branch. Also helps if you're working on a couple of things at once.