search

SNEWS2 / snewpdag

SNEWS2 alert calculations
BSD 3-Clause "New" or "Revised" License
2 stars 13 forks source link

CM2022 changes with float timestamps #83

Closed tsengj10 closed 2 years ago

tsengj10 commented 2 years ago

This is intended to supersede #82. Changes are currently in progress, but it may be helpful to discuss as the changes are propagated through the code.

tsengj10 commented 2 years ago

Updated for float timestamps for now. Ran most of the recipes in the Makefile. Please take a look @mcolomermolla

DtsCalculator and EvalMap aren't updated much (and DtsCalculator taken out of the module for now), because a certain amount of rewriting is needed.

mcolomermolla commented 2 years ago

I made a first review after going through it. However, I did not see the new changes in the branch dwb-cm22-floats in this or a separate PR. Are you just waiting to first merge this one?

tsengj10 commented 2 years ago

Inclined to merge soon. May need to rename the histogram value/gen/renderer objects later.

EvalMap will need updating, or, more accurately, debugging needs to continue to EvalMap. Probably remove gen.NeutrinoArrivalTime as well, now that we have some better implementations.