Typo: Warren equation of state should be 'SFHo' not 'LS220'.

SNEWS2 / snewpy

A Python package for working with supernova neutrinos

https://snewpy.readthedocs.io

BSD 3-Clause "New" or "Revised" License

26 stars 19 forks source link

Closed joesmolsky closed 2 years ago

joesmolsky commented 2 years ago

In the definition of the Warren_2020 class, the variable 'eos' is set to 'LS220' by default.

The link in the documentation (https://doi.org/10.5281/zenodo.3667908) and the paper (https://arxiv.org/pdf/1912.03328.pdf) indicate the equation of state used is 'SFHo'.

sybenzvi commented 2 years ago

@joesmolsky, good catch. Do you mind changing this and making a PR?

joesmolsky commented 2 years ago

Pull request submitted and pending review @sybenzvi .

sybenzvi commented 2 years ago

Closed in PR #187.