Closed sgriswol closed 2 years ago
Here’s the corresponding astropy PR; it looks like this was added in astropy 4.3. Hopefully, for most users pip will install the latest astropy version, so they won’t run into this problem; but making this version requirement explicit in requirements.txt
can’t hurt. (In particular, astropy 4.3 supports the same Python versions as 4.2 (namely, Python 3.7 and higher) so there should be no compatibility issues in that regard.
Attempting to initialize the
Kuroda_2020
model with code like the following, while using astropy v4.2.1 yields a rather uninformative error. This error seems to involve a data column that is expected to have astropy units, but doesn't when the model file is actually loaded. This same error is thrown for all threeKuroda_2020
models. Note that the line numbers displayed below may not correspond to the main branch, but do correspond toKuroda_2020.__init__
.I will note, running the same code in astropy 4.3.1 yields no errors. Would it be appropriate/sufficient to add a version requirement (
astropy >= 4.3.1
) to therequirements.txt
?Example Code:
Error: