search

SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

zenodo_downloader type annotation incompatible with Python 3.9? #197

Closed sybenzvi closed 2 years ago

sybenzvi commented 2 years ago

The zenodo_downloader has a type annotation in line 44 that may be incompatible with Python <3.10. We should maintain backwards compatibility at least to Python 3.7.

sybenzvi commented 2 years ago

I committed the change md5: str|None = None -> md5: Optional[str] = None, which is admittedly uglier but is compatible with versions of Python that we support.