search

SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

Fix access to Warren_2020 models on Zenodo. #202

Closed sybenzvi closed 5 days ago

sybenzvi commented 2 years ago

The model_registry_jan22 branch now supports downloading the Warren_2020 models from Zenodo, but we discovered that the untarred HDF5 files available on Zenodo do not cover all of the simulations from Warren et al. As a result, the Warren_2020 unit tests have been temporarily disabled.

It does appear that the three uploaded tarfiles stir_multimessenger_a1.23.tar, stir_multimessenger_a1.25.tar, and stir_multimessenger_a1.27.tar do contain the missing files. So we need to:

JostMigenda commented 1 year ago

For now, in #184 we have returned to downloading the Warren_2020 model files (individual .h5 files, not the .tar files) from GitHub. See discussion in there for some more problems we’ve encountered with unit tests and downloading tar files.

sybenzvi commented 5 days ago

I'm closing this ticket as we've moved all models to https://github.com/SNEWS2/snewpy-models-ccsn and are happy with downloading them from this location.