search

SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

`init_model` convenience function #225

Closed JostMigenda closed 3 days ago

JostMigenda commented 1 year ago

The init_model convenience function was added in #184 to try out; but is currently hidden in snewpy.models.util, which is (a) not included in the docs and (b) probably not a submodule that we’d want to expose to the user.

There’s also Andrey’s comment about whether to require e.g. "ccsn.Nakazato_2013" as an argument instead of just "Nakazato_2013".

JostMigenda commented 1 year ago

I’ve moved the function to snewpy.models in #230.

JostMigenda commented 1 year ago

Also: Should this still use the get_models downloader (which downloads all progenitors for that model family) or should it use the new downloader (which only loads the requested progenitor)?

JostMigenda commented 5 days ago

Almost two years later, we’ve never actually needed this convenience function; so let’s remove this dead code.

sybenzvi commented 4 days ago

Remove the stub code (@JostMigenda ) and then close the ticket.