search

SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

Basic support for SNOwGLoBES v1.3 #229

Closed JostMigenda closed 1 year ago

JostMigenda commented 1 year ago

Fixes #201 and should be used together with the upcoming version of SNOwGLoBES (see PR SNOwGLoBES/snowglobes#19).

Note: To support CEνNS channels, we would need to allow channel-specific energy binning; whereas the SimpleRate implementation currently assumes that all channels for a given material use the same energy binning. This PR does not yet support CEνNS channels; it only includes changes to ensure that existing code keeps working with the new SNOwGLoBES version.

JostMigenda commented 1 year ago

Note: The automated integration tests currently fail because the smearing matrices are in a different directory in SNOwGLoBES 1.3; so when testing this PR with SNOwGLoBES 1.2, it doesn’t find the smearing matrices and fails the test.

I’ve tested it locally, but will be sure to merge the SNOwGLoBES PR first and then re-run the tests before merging this PR.

JostMigenda commented 1 year ago

Hmm. On rerunning the integration tests, there are some more issues related to the icecube and ar40kt smearing files provided by SNOwGLoBES. The IceCube one is straightforward, I'll fix that in the next few days. The other one may take longer.

github-actions[bot] commented 1 year ago

Result of Benchmark Tests

Benchmark Min Max Mean
python/snewpy/test/test_05_snowglobes.py::test_simulation_chain_benchmark 5.32 5.57 5.41 +- 0.10
JostMigenda commented 1 year ago

I just re-ran the tests after @Storreslara and I made the necessary SNOwGLoBES fixes. Everything’s working now; so we can

I feel like I’m about to come down with a flu; but if I’m well enough, I can try to do this after the SNEWS call tomorrow.