SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

Model registry cleanup #230

Closed JostMigenda closed 1 year ago

JostMigenda commented 1 year ago

This fixes #224. Two things I want to highlight in particular:

During the review, please note that thus far, I’ve only updated Nakazato_2013.ipynb with the new model initialisation. Let me know if that looks reasonable; if so, I will update

before we can merge this PR.

github-actions[bot] commented 1 year ago

Result of Benchmark Tests

Benchmark Min Max Mean
python/snewpy/test/test_05_snowglobes.py::test_simulation_chain_benchmark 4.32 4.45 4.38 +- 0.05
JostMigenda commented 1 year ago

snewpy.models._init_model should be public-facing.

Eventually, yes. But for now, I think it’s not yet ready—see #225. For this PR, I just wanted to move that out of the util.py file so I could delete that as part of the cleanup.