Closed JostMigenda closed 1 year ago
I tested and it works for me. Also I think that's a really nice improvement for the SNEWPY usability - it will allow pip install
ing it with all the dependencies rightaway 👍🏻
A couple of notes after testing:
The SNOwGLoBES PR is now merged and snowglobes_data
is published on PyPI. With that, I think this PR is ready.
@mcolomermolla Can you please confirm whether I’ve resolved all your comments?
Closes #208. I’ve just filed SNOwGLoBES/snowglobes#21, which would help publish SNOwGLoBES data files as a PyPI package. This would simplify snewpy installation (users no longer need to download SNOwGLoBES manually) and usage (no need to specify the SNOwGLoBES directory in
snewpy.snowglobes
function calls).To test this:
pip install -i https://test.pypi.org/simple/ snowglobes_data
SNOwGLoBES_usage.ipynb
and setSNOwGLoBES_path
toNone
.This PR is currently marked as a draft, because there are a few open To-Dos:
importlib_resources
library under Python 3.9