SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
26 stars 19 forks source link

Use snowglobes_data package instead of hardcoded path #235

Closed JostMigenda closed 1 year ago

JostMigenda commented 1 year ago

Closes #208. I’ve just filed SNOwGLoBES/snowglobes#21, which would help publish SNOwGLoBES data files as a PyPI package. This would simplify snewpy installation (users no longer need to download SNOwGLoBES manually) and usage (no need to specify the SNOwGLoBES directory in snewpy.snowglobes function calls).

To test this:

  1. Run pip install -i https://test.pypi.org/simple/ snowglobes_data
  2. Then install snewpy from this branch
  3. Open SNOwGLoBES_usage.ipynb and set SNOwGLoBES_path to None.

This PR is currently marked as a draft, because there are a few open To-Dos:

Sheshuk commented 1 year ago

I tested and it works for me. Also I think that's a really nice improvement for the SNEWPY usability - it will allow pip installing it with all the dependencies rightaway 👍🏻

mcolomermolla commented 1 year ago

A couple of notes after testing:

JostMigenda commented 1 year ago

The SNOwGLoBES PR is now merged and snowglobes_data is published on PyPI. With that, I think this PR is ready.

@mcolomermolla Can you please confirm whether I’ve resolved all your comments?