Implementation of Quantum Decoherence in vacuum

SNEWS2 / snewpy

A Python package for working with supernova neutrinos

https://snewpy.readthedocs.io

BSD 3-Clause "New" or "Revised" License

26 stars 19 forks source link

Implementation of Quantum Decoherence in vacuum #260

Closed santosmv closed 10 months ago

santosmv commented 1 year ago

The effects are combined with the MSW effect. In this case, the flavor conversion from quantum decoherence happens in vacuum (as in the MSC^e of arXiv:2306.17591), and no Earth matter effects are included in this version.

JostMigenda commented 11 months ago

Sorry for the delay! I just ran the unit tests (GitHub doesn't run them automatically for PRs from first-time contributors, I think) and unfortunately, these are currently failing; it looks like some issue with units. @santosmv, can you please take a look at this?

santosmv commented 11 months ago

Sure, I'll take a look at this.

santosmv commented 11 months ago

It was just missing units of quantum decoherence parameters in the test_04_xforms.py. Upon running this test, some issues were raised in the assertEqual methods, which were also fixed.

JostMigenda commented 10 months ago

Just added a minor edit to clean up some unnecessary unit conversions. (Usually, AstroPy handles those automatically as needed; manual conversions are mainly needed at the end to format for output.)

Otherwise, @mcolomermolla already posted an approving review above; so now that the test succeed, I’ll go ahead and merge. Many thanks @santosmv for your work and congratulations on your first SNEWPY PR! 🎉