search

SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
24 stars 17 forks source link

Update the way model downloader is used in the loaders #291

Closed Sheshuk closed 7 months ago

Sheshuk commented 7 months ago

After #273, #287 (consider this only after those PRs) Closes #290

  1. Moved GarchingArchiveModel from snewpy.models.base to snewpy.models.loaders, because it handles loading model from file. base should be kept for general things.
  2. Created classes LocalFileLoader and RemoteFileLoader in the _model_downloader - both implement the _get_file(filename:str)->Path method.
Sheshuk commented 7 months ago

Closing this, as it was implemented in #296