Implementing preSN registry models

SNEWS2 / snewpy

A Python package for working with supernova neutrinos

https://snewpy.readthedocs.io

BSD 3-Clause "New" or "Revised" License

26 stars 19 forks source link

Implementing preSN registry models #296

Closed Sheshuk closed 6 months ago

Sheshuk commented 9 months ago

Closes #243 Closes #290

Fix model tests which were not using absolute file paths (test_02_models.py)
Moved GarchingArchiveModel from base to the loaders module.
Created new LocalFileLoader class for checking if the requested file exists
And RegistryFileLoader to download the requested file from the _model_downloader

Todo:

[x] Implement RegistryModels for preSN
[x] Add tests for preSN models
[x] Add preSN models to the documentation

JostMigenda commented 6 months ago

I’ve finished looking through the code-level changes; they all look good to me. Thanks a lot, @Sheshuk!

Before I accept and merge this PR, I’d like to try some usage examples. I noticed that the demo notebooks (e.g. https://github.com/SNEWS2/snewpy-models-presn/blob/master/models/Patton_2017/Patton.ipynb) still use the old (filename-based) initalisation, which doesn’t work with this PR. Have you started updating those already, or should I go ahead, update them as I try them out and make a PR on the snewpy-models-presn repo?

Sheshuk commented 6 months ago

Thanks @JostMigenda! I will update these examples, they're rather old in general.