search

SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
24 stars 17 forks source link

Run Jupyter notebooks in CI #322

Closed JostMigenda closed 2 months ago

JostMigenda commented 2 months ago

Closes #252 by running all (ccsn & presn) model notebooks and some general notebooks as part of the integration tests.

(For now, I’m exempting several general notebooks, which e.g. require a hard-coded path to the SNOwGLoBES or models directory. In some cases, there may be workarounds; but it’s gonna get more straightforward with some of the changes planned for v2.0.)

As a nice side effect of testing this, I discovered a few issues with existing notebooks which I’ve also fixed. (In particular, the notebooks I copied over from the snewpy-models-ccsn repo in #313 were not the latest versions and missed changes from #282, so I’m restoring those here.)

JostMigenda commented 2 months ago

Thanks @mcolomermolla! I’ve added a commit to avoid writing those files out by default; good point.