search

SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
24 stars 17 forks source link

Update ccsn_loaders.py #331

Closed jpkneller closed 1 month ago

jpkneller commented 1 month ago

I think there's an error in lines 60-63. It should be _flav.name not flavor.name

JostMigenda commented 1 month ago

Could you explain why?

The model input files don’t distinguish nu_x and nu_x_bar, so _flav is used when constructing the filename to read the nu_x_bar flux from the nu_x file. But after reading the data, outside code shouldn’t have to care about whether the input files distinguish the two. So I think it makes sense to use flavor everywhere else, like we do now?

jpkneller commented 1 month ago

Aah, I was looking at an old version. Forget this PR.

JostMigenda commented 1 month ago

No worries!