Add `Fischer_2020` model

SNEWS2 / snewpy

A Python package for working with supernova neutrinos

https://snewpy.readthedocs.io

BSD 3-Clause "New" or "Revised" License

26 stars 19 forks source link

Add `Fischer_2020` model #347

Closed JostMigenda closed 1 month ago

JostMigenda commented 3 months ago

This PR adds support for the Fischer_2020 model (arxiv:1804.10890); corresponding data files are in https://github.com/SNEWS2/snewpy-models-ccsn/pull/6

Open issues:

[x] Add Jupyter notebook to doc/nb/ccsn/Fischer_2020.ipynb
[x] Add unit tests

Right now, the Jupyter notebook @jpkneller has shared uses features planned for v2.0; but the code itself should work under v1.x in principle, so we could target this PR at either the main or the release_v2.0 branch as needed.

mcolomermolla commented 1 month ago

@jpkneller can you provide the notebook so that we close this PR?

jpkneller commented 1 month ago

I have one but it only works with SNEWPY 2. I'll send it via Slack