SNEWS2 / snewpy

A Python package for working with supernova neutrinos
https://snewpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
27 stars 22 forks source link

Adding Bugli model #354

Closed mcolomermolla closed 3 months ago

mcolomermolla commented 3 months ago
JostMigenda commented 3 months ago

Thanks for the changes; this is now looking quite good!

Regarding the test failures:

=========================== short test summary info ============================
FAILED python/snewpy/test/test_01_registry.py::TestModels::test_Bugli_2021 - KeyError: 'Bugli_2021'
FAILED python/snewpy/test/test_02_models.py::TestModels::test_Bugli_2021 - FileNotFoundError: /home/runner/.astropy/cache/snewpy/models/Bugli_2021/hydro_3d_snewpy_average
===== 2 failed, 62 passed, 26 deselected, 11 warnings in 155.06s (0:02:35) =====

Also, before we merge this we still need a demo notebook.