search

SNIA / Swordfish-basic-web-client

The Swordfish Basic Web Client can connect to one or more Swordfish services (including the Swordfish emulator), and present in a web UI frame the entire Swordfish hierarchy. The basic web client also provides basic capabilities to modify configurable Properties (as specified in the schema), as well an providing a basic interface to add or remove elements from the service through a Web UI.
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

#30 - Does not add items to Redfish collections #33

Closed sravanthikalluri19 closed 6 years ago

sravanthikalluri19 commented 6 years ago

code added to validate the response even though status code is not present

ddeel commented 6 years ago

This pull request does not fix or improve the "Add Items to Redfish collections" problem (#30 ), and it actually makes things worse, because the client is no longer able to remove objects from collections.

The previous version of the client was able to successfully remove objects from collections, but this version of the client always gets a "Deleting a service Failed" message when Remove operations are attempted, and this happens with both Swordfish and Redfish objects.

There is no change to the client behavior for attempts to add objects to Redfish collections. It still does the same things reported in Issue #30 .

sravanthikalluri19 commented 6 years ago

Reverted the changes back for delete a item from existing collection. Checked all possibilities to catch error/success code form api. Able to successfully add/delete item from StorageServices and StorageSystems collections

ddeel commented 6 years ago

The most recent code for this pull request restores the ability to delete items from Redfish and Swordfish collections, but the client is still not able to add items to Redfish collections. Attempts to add items to Redfish collections result in this message: "Error :Adding a new collection/service failed at this moment".

ddeel commented 6 years ago

The latest commit to this pull request appears to fix Issue #34 .

rahlvers commented 6 years ago

Approved in SSM TWG meeting. 7/3/18