search

SNIA / Swordfish-basic-web-client

The Swordfish Basic Web Client can connect to one or more Swordfish services (including the Swordfish emulator), and present in a web UI frame the entire Swordfish hierarchy. The basic web client also provides basic capabilities to modify configurable Properties (as specified in the schema), as well an providing a basic interface to add or remove elements from the service through a Web UI.
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Fails to report a 405 "Method not allowed" error situation #35

Closed rahlvers closed 6 years ago

rahlvers commented 6 years ago

The client appears to make a change (one that cannot succeed), and fails to report a 405 "Method Not Allowed" error situation.

Here is a sequence that shows the issue. The images below are from the current versions of the client and the emulator.

Initial state; shows the StorageServices collection: image

Editing the collection "Name" property to say "ChangedName": image

The change appears to have been accepted without any error after clicking on the Save icon: image

Clicking on a different resource (Chassis): image

Go back to StorageServices and see that the collection's Name property was not actually changed, because it now says "Storage Service Collection" again, instead of "ChangedName": image

This is what happens when the Chrome Restlet tool is used to attempt to PATCH the Name property on the StorageServices collection: image

The issue is that the client is not reporting the 405 "Method Not Allowed" error, and it looks like the operation succeeded, when it has actually failed. The user only discovers the problem by going to a different resource (like Chassis) and then returning to the StorageServices collection.

Note that the client shows this same behavior this for ALL of the Redfish and Swordfish collections, not just the StorageServices collection.

rahlvers commented 6 years ago

Are there any pop-up errors implemented in the web client? Any errors coming from services should be passed through to the end user.

sravanthikalluri19 commented 6 years ago

1.Are there any pop-up errors implemented in the web client? Yes @rahlvers . Error messages are shown in the alert boxes. 2.Any errors coming from services should be passed through to the end user. Only few service calls are sending the error message's as a response according to my observation.

We will look into the issue and update .

ddeel commented 6 years ago

Note that the Redfish Interface Emulator master branch was updated last Thursday. Any testing of the client should be done with an updated version of the Swordfish API Emulator that is based upon the updated Redfish Interface Emulator.

Running with an updated Swordfish API Emulator, I still see exactly the same problem that is being reported above.