Update docs and README for version 1.0

SNL-WaterPower / WecOptTool-MATLAB

WEC Design Optimization Toolbox

GNU General Public License v3.0

12 stars 9 forks source link

Update docs and README for version 1.0 #175

Closed H0R5E closed 3 years ago

H0R5E commented 3 years ago

Description

Update the online Setup page to match the README.
Edit README and docs for MATLAB support policy
Fix typo in Hydrodynamics class docstring
Fix line numbers in optimization example

H0R5E commented 3 years ago

Sterling, I was a bit confused because you've made the changes on a branch in your repo, rather than mine.

ssolson commented 3 years ago

Sterling, I was a bit confused because you've made the changes on a branch in your repo, rather than mine.

Yeah I have decided it is very easy to create PRs. Far easier than trying to select and compare multiple commits someone pushed to my open PR and make sure I know exactly what was changed.

H0R5E commented 3 years ago

OK, I see. But you didn't create a PR in this case, right?

ssolson commented 3 years ago

Apologies. I can't see since you deleted the branch but I guess not! Yes, that would have been confusing!

H0R5E commented 3 years ago

I didn't delete your branch.

ssolson commented 3 years ago

...I know that. I do not know of a way to see if I had a PR open on your deleted branch.

H0R5E commented 3 years ago

The PR would still be on Github, whatever branch you used as the baseline. It would just say that the source branch has been deleted.

ssolson commented 3 years ago

I don't know how to see that. I deleted my branch and I believe I did not submit a PR.