SNL-WaterPower / WecOptTool-MATLAB

WEC Design Optimization Toolbox
GNU General Public License v3.0
12 stars 9 forks source link

WaveBot case A: x-axis integer multiples of fund. freq. #189

Closed ryancoe closed 3 years ago

ryancoe commented 3 years ago

Description

It is nice to label the x-axis for this case with integer multiples of the fundamental frequency to better highlight the harmonics. I've also remove the xticklabels from the first row of axes.

94573158-0bd29280-022f-11eb-9665-40ed1c0cc196

Checklist:

ryancoe commented 3 years ago

All tests pass: test_results.pdf

H0R5E commented 3 years ago

@ryancoe, I can't run this case, so you should probably ask Sterling to take a look at it.

ryancoe commented 3 years ago

@H0R5E - What's preventing you from running this case?

ssolson commented 3 years ago

Ryan Case C uses the "Global optimization toolbox" not the optimization toolbox. So I can look into this.

ryancoe commented 3 years ago

This is caseA -- my mistake in labeling the PR.

H0R5E commented 3 years ago

So, I have pushed some of the functionality in this case to the Performance class plot functions (such as setting the interpreter and font size) and tidied up a bit. This also sets the font of the x and y axis labels to latex, which I think is how it should be.

The other change I made here was to change 1 \omega to simply \omega in the x-axis tick labels. It's unusual to put 1 * x rather than just x.

If you feel OK with these changes, then I'd be happy for this to be merged now.

ryancoe commented 3 years ago

All tests pass and looks good to me: test_results.pdf