search

SNL-WaterPower / WecOptTool-MATLAB

WEC Design Optimization Toolbox
GNU General Public License v3.0
12 stars 9 forks source link

Support MHKiT Generated Spectra #88

Closed H0R5E closed 3 years ago

H0R5E commented 4 years ago
  • Why not use MHKiT instead of WAFO? This is also developed through WPTO funding and we can modify it as need be to support this program. It would be nice to see WPTO funded projects leverage other WPTO funded projects.

Originally posted by @kmruehl in https://github.com/SNL-WaterPower/WecOptTool/issues/65#issuecomment-605360662

Although MHKiT shouldn't replace WAFO as the primary spectrum format, due to its dependency on Python as discussed below, it would be helpful if we were able to support spectra generated by MHKiT users.

This could be as a conversion to WAFO format in MHKit or here in WecOptTool.

ryancoe commented 4 years ago

Unless I misunderstand, MHKit in MATLAB is a wrapper for MHKit Python. I don’t think its worthwhile to make the user install Python. As a third option, we can also code up our own sea states pretty easily.

H0R5E commented 4 years ago

Agreed. I didn't realise it requires a python dist to run, sorry. Closing.

H0R5E commented 4 years ago

Reopened with a different perspective.

kmruehl commented 4 years ago

it would be helpful if we were able to support spectra generated by MHKiT users.

This could be as a conversion to WAFO format in MHKit or here in WecOptTool.

I agree with that statement. Please let the MHKiT team know how we can help. And yes, MHKiT has a dependency on Python, but the pro of this approach is that there are no additional MATLAB toolboxes required to run MHKiT-MATLAB. I haven't run WAFO in years, but I thought it had some MATLAB package dependencies. yes/no?

ssolson commented 3 years ago

The focus of the WecOptTool is on control codesign. At this time given the limited project budget, this feature is seen to offer little to no capabilities over using WAFO. We can revisit/ reopen in the future.