search

SNL-WaterPower / siweed

Sandia Interactive Wave Energy Education Display (SIWEED)
5 stars 2 forks source link

Touchscreen #35

Closed delaneyheileman closed 3 years ago

delaneyheileman commented 4 years ago

The touchscreen functionality is now working. I had to edit the library files and recompile the .jar - currently the library is set to touchscreen as a default but when I ran the program on my Mac this didn't seem to affect anything. Button colors (issue 34) are still a bit wonky so we can wait until I fix those to merge if anyone feels strongly about that

ryancoe commented 4 years ago

@delaneyheileman - In the interest of having it completed soon, I'm going to pass the buck to @nickross4444 on this review.

nickross4444 commented 4 years ago

@delaneyheileman The sliders are working for the most part, but the buttons still seem to require a double tap for me. Instead of the way it was before, the second tap can be anywhere. I'm not sure how to explain the bug with the sliders. Is it working properly on the demonstration laptop? Also, @ryancoe shouldn't this merge be into develop?

ryancoe commented 4 years ago

@nickross4444 - yes, good catch: I've switched it to merge into develop now

SeanPluemer commented 3 years ago

@delaneyheileman I think we should close this pull request and branch since it was just changed into the more recent pr. What do you think?

nickross4444 commented 3 years ago

@SeanPluemer @delaneyheileman I agree with Sean we should probably close this.