search

SNSystems / dexter

DExTer - Debug Experience Tester
MIT License
33 stars 6 forks source link

Add program state class and command #26

Closed SLTozer closed 5 years ago

SLTozer commented 5 years ago

This PR includes the "final" form of the syntax and basic command, but does not have complete functionality. Currently only local variables are watchable, and Visual Studio gives no locations for frames below the top of the stack. The former will be fixed in a later PR that changes the existing approach to watching expressions, the latter is simply a problem whose solution is unclear and does not seem important enough to hold up the rest of the work, which is blocking other changes.

OCHyams commented 5 years ago

Las two changes look good (great test!) -- LGTM.

OCHyams commented 5 years ago

I won't accept though in case @jmorse has any final words. Not sure I can even accept given I can't see a button anywhere.

jmorse commented 5 years ago

Do we prefer rebase-and-merge or squash-and-merge?

SLTozer commented 5 years ago

Do we prefer rebase-and-merge or squash-and-merge?

Squash and Merge is the way I believe - it guarantees 1 commit per PR, and doesn't leave a merge history behind