search

SNSystems / dexter

DExTer - Debug Experience Tester
MIT License
33 stars 6 forks source link

Allow Dexter commands to specify subcommands #31

Closed OCHyams closed 5 years ago

OCHyams commented 5 years ago

This allows additional globals to be passed to eval() without allowing the user to call the subcommands globally in the test file.

This is required for #30. I can bundle the changes into that PR if necessary but I thought it might be clearer to separate them out.

OCHyams commented 5 years ago

Squashed changes -- some small tidy ups and removal of unnecessary eval() call introduced with the original change.

OCHyams commented 5 years ago

Squashed in a couple more QOL changes.

TomWeaver18 commented 5 years ago

LGTM, however, gonna be some fallout when DexLabel goes on top of this, but will cross that bridge when it get's to it.

OCHyams commented 5 years ago

I don't expect there to be too many problems resolving the conflicts with your PR (#33). We can work through them together if they turn out to be nasty.