search

SNSystems / dexter

DExTer - Debug Experience Tester
MIT License
33 stars 6 forks source link

Debuginfo tests #53

Closed SLTozer closed 5 years ago

SLTozer commented 5 years ago

Contains some minor additional changes that were useful or necessary in the development of this work, most significantly changing DexExpectProgramState to check all the fields of an expression value, rather than just its literal value.

OCHyams commented 5 years ago

LGTM, good stuff.

EDIT: What's the plan for the remaining debuginfo tests?

OCHyams commented 5 years ago

Left an inline comment.

For the sake of coverage I think we should have a feature_test which tests fields of the watch { expr: value_info_dictionary } where value_info_dictionary contains fields other than just value.

I guess the obvious question is when the are other 12 C-language tests are coming? +1

Otherwise this is still looking good.

jmorse commented 5 years ago

LGTM, many thanks for value/dict split in a program state.

AFAIK, there's no reason to not merge this now?

SLTozer commented 5 years ago

I believe so; the other debuginfo-tests can come in a separate patch, and all comments have been resolved.