search

SNSystems / dexter

DExTer - Debug Experience Tester
MIT License
33 stars 6 forks source link

Fix DexExpectStepKind to match expected behaviour in feature_tests #57

Closed OCHyams closed 5 years ago

OCHyams commented 5 years ago

feature_tests/commands/perfect/expect_step_kind

/recursive This test was failing because the 'previous step' was in the same function, and dexter assumed this meant no call had happened. This has been fixed by checking if the call stack has grown between steps instead.

/small_loop The call to 'func' on line 20 returns to line 19. Dexter was treating steps out of a function as a 'FUNC' StepKind (as well as the expected step into a function). Becayse of this, the 'BACKWARD' step was being hidden by a 'FUNC' StepKind. Steps out of a function no longer count as 'FUNC'.

The docs have been updated to explain the different StepKind values.

NOTE: This is based on #56. The first two commits are from that Pull Request.

OCHyams commented 5 years ago

I have not yet updated the existing dexter tests to use this 'fixed' DexExpectStepKind. I'll put up a patch for that shortly.

OCHyams commented 5 years ago

Please don't merge this yet.

OCHyams commented 5 years ago

Please see https://github.com/SNSystems/dexter/pull/59