OCHyams
commented
5 years ago NOTE: This should "Just work" with the annotate-expected-values (AEV) tool so long as the input dextIR pickle and dexter are the same 'version'. This could be seen as an argument for encoding some kind of version number in the dextIR (in another patch!).
NOTE: I can separate this out into different pull requests if necessary.
Each commit has a message explaining what's going on. But, on a high level:
FUNC was counting steps OUT of functions.
Fixing FUNC showed many more than expected BACKWARD steps. This is because BACKWARD/FORWARD was counting column movement as well as lines. This makes sense but is not very obvious from a test-writer/reader's perspective. See the example in Commands.md in commit 9dc209d "Fix DexExpectStepKind to match expected behaviour in feature_tests".
To reduce confusion, I've removed BACKWARD and FORWARD, and added: VERTICAL_FORWARD: line++ VERTICAL_BACKWARD: line-- HORIZONTAL_FORWARD: column++ HORIZONTAL_BACKWARD: column--
I'm open renaming HORIZONTAL* to COLUMN and VERTICAL_ to LINE_*, or anything else, if anyone feels strongly about this.