I recommend running black (install with python -m pip install black) over the codebase with default settings (add --line-length 80 if necessary as default is 88) before submitting the RFC.
Remove feature_tests/style/ so that feature_tests only ensure that the tool
is functioning correctly.
Remove --lint option from Dexter for the following reasons:
Style has not been strictly enforced.
Many changes have been commited which were not checked for style.
The --lint option and yapf-format.py script disagree.
Running yapf-format.py over Dexter doesn't sate --lint.
Python 2 to 3 migration.
Previous style efforts may be outdated.
An upstream Dexter patch is being prepared.
Reducing complexity for the initial RFC will be helpful.
linter hint comments (e.g. # pylint) have been left in to reduce future work
if/when a new linter is chosen.
TomWeaver18
commented
5 years ago
NOTE:
black(install withpython -m pip install black) over the codebase with default settings (add--line-length 80if necessary as default is 88) before submitting the RFC.Remove feature_tests/style/ so that feature_tests only ensure that the tool is functioning correctly.
Remove --lint option from Dexter for the following reasons:
Style has not been strictly enforced.
The --lint option and yapf-format.py script disagree.
Python 2 to 3 migration.
An upstream Dexter patch is being prepared.
linter hint comments (e.g.
# pylint) have been left in to reduce future work if/when a new linter is chosen.