SNSystems / dexter

DExTer - Debug Experience Tester
MIT License
33 stars 6 forks source link

Fix failing whitespace parse unittests #66

Closed OCHyams closed 4 years ago

OCHyams commented 5 years ago

NOTE: This is based on #65. Commits for this review start at 3db5945.

Split whitespace parsing unittest into 'good' and 'bad'. Parsing 'bad' whitspace throws an exception so we should separate it from the 'good' whitespace.

Fix failing unittests test_parse_good_whitespace and test_parse_bad_whitespace. The following is now consumed by dexter, matching python whitespace rules:

Command        ()
                ^^^^ Horizontal whitespace before open paren.

Fix failing parsing unittest test_parse_share_line. This allows users to do this: some_cpp(); // DexLabel('end_0') DexLabel('start_1') It will be especially handy for using labels next to the deprecated command DexWatch() when annotate-expected-values is revived.

OCHyams commented 4 years ago

Rebased