Revert "Set SUBSYSTEM:WINDOWS as the default environment on Windows (…

SNSystems / dexter

DExTer - Debug Experience Tester

MIT License

33 stars 6 forks source link

Revert "Set SUBSYSTEM:WINDOWS as the default environment on Windows (… #68

Closed OCHyams closed 4 years ago

OCHyams commented 4 years ago

…#54)"

This reverts commit d370454790545316ce92c22e7a2bdc754cd8bda7. There are two problems with the patch.

Before d370454, --ldflags args were passed to the compiler driver (e.g. clang-cl.exe). With d370454 they are passed after /link, which means /Zi in --ldflags gets ignored and no debug data is generated for windows targets.

/SUBSYSTEM:WINDOWS /ENTRY:mainCRTStartup isn't cross-compile friendly.

OCHyams commented 4 years ago

I think we should bake /link /SUBSYSTEM:WINDOWS /ENTRY:mainCRTStartup in to a lit substitution for WW test runs.

TomWeaver18 commented 4 years ago

it's not clear to me what the potential fix would be, but I'm happy to see this reverted. Just need to regroup and tackle this again when we've some clear air.