Fix source-file detection in dbgeng

SNSystems / dexter

DExTer - Debug Experience Tester

MIT License

33 stars 6 forks source link

Fix source-file detection in dbgeng #76

Closed jmorse closed 4 years ago

jmorse commented 4 years ago

Dbgeng coughs up very different file paths to the ones that dexter believes identifies the source files it's working on. Allow debuggers to work out whether we're currently in a source file themselve,s through overriding a DebuggerBase method.

jmorse commented 4 years ago

Righty, that should both correctly compare paths, and not freak out when one of the paths doesn't exist

OCHyams commented 4 years ago

LGTM.

I'd personally consider putting the exists(a) and exists(b) and samefile(a, b) in a function since it's used in a lot of places, but this is not a blocker for me.