search

SNSystems / llvm-project-prepo

Fork of LLVM with modifications to support a program repository
26 stars 0 forks source link

Rename “compilation member” as “definition” #134

Closed paulhuggett closed 3 years ago

paulhuggett commented 3 years ago

(See also pstore PR #77 which is a prerequisite for this PR.)

A long time ago we decided to rename the repo’s “compilation member” as ”definition” to better represent its role in the schema. It’s documented this way on the prepo glossary page. Since then I’ve tried to ensure that new code used the new terminology, but there never seemed to be a good time to change the old. This has result in a confusing mishmash of terms that really needs to be resolved.

paulhuggett commented 3 years ago

Some comments use the compilation member:

I would have sworn that I’d searched for all of the various spellings and capitalisations in both projects. Guess I missed one… af0d2b1bb05b7c185b3a875e8ef6dfa6ce9cae99.

paulhuggett commented 3 years ago

LGTM!

Thanks. I can’t of course commit this work until the matching pstore API change has been committed.