search

SNSystems / llvm-project-prepo

Fork of LLVM with modifications to support a program repository
26 stars 0 forks source link

Fix for #142. Use the cwd if no path is specified. #143

Closed paulhuggett closed 3 years ago

paulhuggett commented 3 years ago

Is it possible to add a lit test for this issue?

I don’t know. Do its various shells all support changing the working directory as part of the test?

MaggieYingYi commented 3 years ago

Is it possible to add a lit test for this issue?

I don’t know. Do its various shells all support changing the working directory as part of the test?

The test is for the repo-create-ticket tool. The output doesn't support only filename (without path) before you fix the issue. Your change make the --output support the filename. We could add a test for the repo-create-ticket, just like we did for repo2obj tool.

paulhuggett commented 3 years ago

The test is for the repo-create-ticket tool. The output doesn't support only filename (without path) before you fix the issue. Your change make the --output support the filename. We could add a test for the repo-create-ticket, just like we did for repo2obj tool.

Yes, but that doesn’t answer my question! I don’t know if it’s possible to write such a test. There’s no equivalent test for repo2obj.

MaggieYingYi commented 3 years ago

Yes, but that doesn’t answer my question! I don’t know if it’s possible to write such a test. There’s no equivalent test for repo2obj.

Sorry, I didn't quite get what you said.

I think we can add a test as you mentioned in the issue https://github.com/SNSystems/llvm-project-prepo/issues/142#issue-854353263

% repo-create-ticket -o foo.o --repo=clang.db 51fdad67cdc0518e6113954e60de80d9
error: No such file or directory

Before the fix, the test failed. After this fix, the test passed.

Does it make sense to you?

paulhuggett commented 3 years ago

I think we can add a test as you mentioned in the issue #142 (comment)


% repo-create-ticket -o foo.o --repo=clang.db 51fdad67cdc0518e6113954e60de80d9
error: No such file or directory

Unfortunately, this will write a file ”foo.o” into a random directory (which ever happens to be the working directory when the test ran). I don’t think that’s acceptable. For the test to be possible, I would need to set the cwd to a known location.

MaggieYingYi commented 3 years ago

I think we can add a test as you mentioned in the issue #142 (comment)

% repo-create-ticket -o foo.o --repo=clang.db 51fdad67cdc0518e6113954e60de80d9
error: No such file or directory

Unfortunately, this will write a file ”foo.o” into a random directory (which ever happens to be the working directory when the test ran). I don’t think that’s acceptable. For the test to be possible, I would need to set the cwd to a known location.

Thanks for explanation. I see now.