search

SNSystems / llvm-project-prepo

Fork of LLVM with modifications to support a program repository
26 stars 0 forks source link

Install the repo-based LLVM libraries and database. #155

Closed MaggieYingYi closed 3 years ago

MaggieYingYi commented 3 years ago

Current, only LLVM ELF libraries (using repo2obj) are installed.

This commit includes:

  1. rename the ELF libraries from name.a to name_elf.a.
  2. install the repo based LLVM libraries and the corresponding databases.
  3. repo wrap tool generates both repo and elf libraries.
paulhuggett commented 3 years ago
  1. repo wrap tool generates both repo and elf libraries.

I’m not at all sure that this is a feature that the wrap tool should have. This tool is intended enable someone to transparently use traditional ld/ar tools with ticket files produced by the compiler. Creating different kinds of output should be the job of the build system.

MaggieYingYi commented 3 years ago

Creating different kinds of output should be the job of the build system.

I have updated the patch at commit https://github.com/SNSystems/llvm-project-prepo/pull/155/commits/d469cab8fe92845eb0866d477273d3f96ee53c3f.

The changes include:

  1. revert the change of wrap_tool.py.
  2. Modify the repo.cmake file to use standard ‘ar’ to archive all ticket files.
  3. Add the new repo2obj.cmake to use archive.py file to archive all ELF files which are generated using repo2obj.
  4. Modify the Makefile to support the repo-based libraries and database.
MaggieYingYi commented 3 years ago

Thanks for discussing the patch with me over the phone. I have updated the patch correspondingly.