SNflows / flows

Flows Pipeline
https://flows.phys.au.dk
GNU General Public License v3.0
3 stars 4 forks source link

Lock pipeline dependencies to sensible semversions. #53

Closed emirkmo closed 1 year ago

emirkmo commented 2 years ago

The photometry pipeline needs to be cleaned from the API and other parts, and should be locked to sensible but not too old semversion for the dependencies. For example, currently it's not possible to pip install astropy 4.1 on newer python version because of incompatibility with Jinja2 version in its build dependencies. If we don't have a reason for staying on 4.1, we should test moving up, at least to 4.3, and later to 5.0. Astropy versions are technically LTS supported for 2 years.

However, we should also lock the dependencies, make only 1 version of python a required CI check (because this will be a pipeline/app that is locked and using that version). We can over time bump that python version (we don't have to lock the python version though). We can continue testing against py3.9 and py3.10, in preparation for moving to them, but don't need to require it to be working.

emirkmo commented 2 years ago

I ran a bunch of tests on test_ci branch, and this Jinja2 issue is very annoying to workaround.

I can actually get it working on ubuntu, but astropy fails to build on Windows, and sci-kit image fails on Mac OS for py>3.9.

emirkmo commented 2 years ago

Astropy can be Brought to 5.1 with the pending change to g2d fitting.

Numpy, matplotlib, scipy, scikit learn be brought to latest according to the test, pending the results from the "master" log.