search

SO-Close-Vote-Reviewers / UserScripts

Various user scripts that add features to the review queue or to the chat room
Other
57 stars 41 forks source link

URRS: don't reformat posts/xxx/timeline links #167

Open tripleee opened 5 years ago

tripleee commented 5 years ago

The option "Change bare question URLs to the question's title." should arguably not change links which are not links to questions.

Currently it does this for timeline links, such as https://chat.stackoverflow.com/transcript/message/46547750#46547750, as shown in this screen shot of how my Chrome renders that chat message:

Screenshot 2019-06-19 at 21 59 23

The actual link in that message is https://stackoverflow.com/posts/56645139/timeline

I have not examined the source code to pinpoint the place where this is happening. I'm thinking anything which ends with /timeline should be easy to exclude, though I imagine there might be other patterns which should be added as well. (Resisting the urge. Wait, oops.)

makyen commented 5 years ago

I'm more inclined to have the link text change to "Timeline for: Is there a function to check the continuity in a list?", rather than not change the link text at all. Assuming that was the resolution, I'd call this more an enhancement rather than a bug, but I could see it both ways.

tripleee commented 5 years ago

No objection, though then the option should perhaps be relabelled to reflect its wider scope...?

makyen commented 5 years ago

Does the following changed text meet your expectations:

URRS changes to timeline, revisions, edit bare URLs

I'll also change the wording on that option.

tripleee commented 5 years ago

Looking good, yeah. Thanks!