makyen
commented
2 years ago Basically repeating what I said in chat:
I'm sorry it took so long to act on this and get the features into the script.
I'd also added the Ministry to my local copy shortly before I was aware you wanted it. I was going to just use your PR, but there were some general issues with adding it which I'd already resolved in my copy (IIRC, it was mainly the order in which the options appeared in the in-chat move-menu, but I'd have to look at the commits to double-check). So, I flaked on doing more work to re-integrate that into your PR and ended up just using what I already had. I'm sorry it ended up that way.
The "Ministry of Silly Hats" is added as a destination room for SOCVR, since it is often used as a place to shunt over extended and/or off-topic discussions.
(This PR arose out of my frustration a few moments ago at having carefully selected the individual messages to be migrated using the script's tooling, and then finding that the Ministry was not one of the supported destinations. I then had to re-select the exact same messages using the chat server's built-in move messages tool. That does work just as well, unless you do the wrong thing first, then it works substantially less well. Having the Ministry as a standard destination frees one from having to remember two different workflows and choosing the correct one at the outset.)
However, it's more like a black hole in the sense that no messages should ever be migrated from it into SOCVR, so a separate category was created for this room, making it otherwise behave like the SO chat defaults.