search

SO-Close-Vote-Reviewers / UserScripts

Various user scripts that add features to the review queue or to the chat room
Other
57 stars 40 forks source link

Disable CV Request Generator script on Meta #97

Closed 501st-alpha1 closed 1 year ago

501st-alpha1 commented 7 years ago

According to rene in chat here, SOCVR doesn't accept cv-pls / reopen-pls requests for Meta. Thus, I'd like to request that the CV Request Generator script be disabled on Meta sites.

Tiny-Giant commented 7 years ago

The close vote request generator currently has a room list feature which allows you to add and remove target rooms for each site. As there is no guarantee that all users are using this solely for sending requests to the SOCVR, I don't think it would be appropriate to prevent the request generator from displaying on any given site. It may be more ideal to prevent SOCVR from being the default on any site other than Stack Overflow. This requires more discussion.

makyen commented 7 years ago

I'm currently working on updating the script. I had identified this as an issue and agree with @Tiny-Giant that the possibility that this script is being used by people to send requests from other sites to other chat rooms conflicts with just turning off the script on non-SOCVR moderated sites (i.e. everything other than stackoverflow.com).

I'm open to implementing whatever the consensus is that we should have.

I have currently implemented (but not yet filed a PR):

  1. An option that allows the user to disable showing the button for the CV-request GUI on all non-SOCVR moderated sites (i.e. everything other than stackoverflow.com). The default is that the button for the CV-request GUI is shown on all sites, retaining the current functionality.
  2. An option that on non-SOCVR moderated sites do both (default: not enabled, retains current functionality):
    1. Limit the type of requests which the user can select to [Smoke Detector (SD) !!/report, SD !!/reportuser, spam, and offensive]1.
    2. Select Charcoal HQ as the default chat room to send requests to, unless the user has selected a different chat room (through the normal room selection interface).
  3. Below the request preview (new functionality) a notice that SOCVR does not moderate the current site (if the target chat room is SOCVR). This is treated as just another type of request validation failure.2
  4. When the user clicks on "Send" to send a request to SOCVR from a non-SOCVR site, they will get a confirmation dialog stating that SOCVR does not moderate that site and asking them to confirm that they really want to send the request.2

For the options, changing the default behavior between enabled/disabled is trivial, should people feel the default should be set differently. The user, of course, can set the options as desired.

  1. There is new functionality that, under normal circumstances (i.e. on SO), the user can select the type of request message from: [cv-pls, reopen-pls, del-pls, undel-pls, Smoke Detector (SD) !!/report, SD !!/reportuser, spam, or offensive]. The default request-type is determine by if the request is about a question or answer (new functionality: request button on all answers) and the current status of the post (e.g. cv-pls for an open question, reopen-pls or del-pls for a closed question, undel-pls on a deleted question, del-pls/undel-pls on answers depending on their state).
  2. Request validation is a new feature. This is things like: request exceeds 500 characters; trying to send a reopen-pls on an open question; send a del-pls on a question or answer that can't be delete voted, etc. User is informed of the problem below the request preview and must click through a confirm dialog to actually send the request.
makyen commented 1 year ago

Thanks for the report. This was resolved by switching the repository over to the 2.X version of the Request Generator, if not before. If it's still an issue, please post a new comment here, reopen this issue, or create a new issue.