UPSTART 02: Testing, Tooling, Refactoring - Githubissues

SOA-04 / leaf-api

0 stars 3 forks source link

UPSTART 02: Testing, Tooling, Refactoring #32

Open jerry914 opened 1 week ago

jerry914 commented 1 week ago

Tasks Overview

Create a library project: ✅
Update project structure: ✅
Stub web tests with VCR + WebMock: ✅
Check test coverage: ✅
Create Rake tasks: ✅
Fix code smells: ❌ Please run reek to detect and fix code smells.

Rubocop Offenses

Perfect! No issues were found. Great job!

pedestrianlove commented 6 days ago

@jerry914 Aside from the function in here, everything is fine now: (fixed in #42 ) https://github.com/SOA-04/leaf-api/blob/536a22d0212617be147c5bcc101e453da23e7677/lib/leaf_api/service/nthu_api.rb#L14-L31 https://github.com/SOA-04/leaf-api/blob/536a22d0212617be147c5bcc101e453da23e7677/.reek.yml#L1-L10

This is due to the inherent design of the API provider, the API library function wouldn't make sense otherwise: https://api.nthusa.tw/docs#/Buses/get_stop_bus_buses_stops__stop_name___get

(API requires 4 variables to work)