search

SOA-SCK / PaperDeep

0 stars 0 forks source link

Develop #13

Closed suvincent closed 2 years ago

suvincent commented 2 years ago

Hi @chinyakao

We use the built react files as static files so that we can see the websites when running rackup, or the roda server will only be the api server. We think this is the easier way for deployment because if we do not put the built files on github, we need to deploy twice time : the ruby api server and react front-end.

chinyakao commented 2 years ago

Hi @suvincent,

Thanks for replying me. Sure, I understand that. Of course you can keep the folder.

wilsonchengsy commented 2 years ago

Hi @chinyakao , Thank you for the review, we will reply the reviews in the next days.

chinyakao commented 2 years ago

Btw, remeber to update secrets_example.yml with necessary real key and fake key. refers to professor's file.

There is a _readme.txt file in app/infrastructure/database/local you can add to let contributor have the local folder. But it is up to you add or not since strict git rule suggest not to do that.

RayhungKao commented 2 years ago

We have revised it and also add new features this week, as detailed in #24