search

SOA-SCK / PaperDeep

0 stars 0 forks source link

Week 11 Review #55

Open suvincent opened 2 years ago

suvincent commented 2 years ago

Week 11 summary:

create Page object for acceptance test : #52 create Form Object #45 create service Object #49 #50 update test data #53 add new feature : citation tree #40 the rest are some patch or bugfix

to sum up , #54 is the PR from develop to main

chinyakao commented 2 years ago

@suvincent @RayhungKao @WilsonCheng-sy

I reviewd your #54 and it is nice work. There are couple quality issue in rubocop and reek. The acceptance test also shows some errors. If you have time, please take a look. Or you have any concern, please let me know.

suvincent commented 2 years ago

Hi @chinyakao ,

we fixed the test in the new api repo https://github.com/SOA-SCK/api-PaperDeep if the error still happen, please let us know

wilsonchengsy commented 2 years ago

Also we solve rubocop issue, and we keep working on reek issue

chinyakao commented 2 years ago

I see. Thank you!