SOBotics / AdvancedFlagging

Userscript to highlight reported posts, and send feedback to Smokey, Natty, Guttenberg and GenericBot.
22 stars 7 forks source link

AdvancedFlagging link not showing on firefox #21

Closed rjrudman closed 6 years ago

rjrudman commented 6 years ago

From this comment

I have an issue with Advanced Flagging not showing up as link below posts. I installed it from https://github.com/SOBotics/AdvancedFlagging/raw/master/dist/AdvancedFlagging.user.js , refreshed an SO post website I had open, cancelled the MS dialog and opened another reported post. However the link still wasn't there. I restarted my browser (Firefox 58.0.1) but still nothing. I also uninstalled Natty Reporter which I had previously installed. Any idea why that might happen?

rjrudman commented 6 years ago

Some extra details:

Windows 7 Firefox 58.0.1 Tampermonkey

Apparently works fine with Windows 10 and Firefox 59.0.1

mvarendorff commented 6 years ago

I reinstalled it now to see if anything changed and now I have something in the console that will hopefully be useful:

Error: no Promise impl found    aws-trusted-adviser-vs-inspector%20line%203%20%3E%20Function:569:19
ERROR: Execution of script 'Advanced Flagging' failed! $ is not defined aws-trusted-adviser-vs-inspector%20line%203%20%3E%20Function:4:296

    anonymous/< https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector%20line%203%20%3E%20Function:4:296
    anonymous/< https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector%20line%203%20%3E%20Function:3:55
    anonymous   https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector%20line%203%20%3E%20Function:3:2
    m</<    https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector:2:367
    E_c https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector:3:190
    ha  https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector%20line%201%20%3E%20Function:62:374
    create  https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector%20line%201%20%3E%20Function:71:259
    h   https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector%20line%201%20%3E%20Function:16:234

tms_e9d06491_ad81_43a0_b003_da1dc3d6db02/</__WEBPACK_AMD_DEFINE_RESULT__<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:1326:5    aws-trusted-adviser-vs-inspector%20line%203%20%3E%20Function:4:381
tms_e9d06491_ad81_43a0_b003_da1dc3d6db02/<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:1323:163
__webpack_require__@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:46:12
tms_e9d06491_ad81_43a0_b003_da1dc3d6db02/<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:1815:202
__webpack_require__@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:46:12
tms_e9d06491_ad81_43a0_b003_da1dc3d6db02/<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:89:18
tms_e9d06491_ad81_43a0_b003_da1dc3d6db02@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:27:11
m</<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector:2:367
anonymous/<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:4:1
anonymous/<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:3:55
anonymous@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 3 > Function:3:2
m</<@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector:2:367
E_c@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector:3:190
ha@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 1 > Function:62:374
create@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 1 > Function:71:259
h@https://stackoverflow.com/questions/48136254/aws-trusted-adviser-vs-inspector line 1 > Function:16:234

So for some reason it looks like jQuery is not included at the time of execution of the script in that case however when checking manually in the console after the page was fully loaded, $ is defined as the usual jQuery function one would expect.

I tried adding // @require https://code.jquery.com/jquery-3.3.1.min.js to the userscript but "no Promise impl found" remained and other warnings I expect to be related to that came up.

mvarendorff commented 6 years ago

Looks like an old version of Tampermonkey caused this issue. After reinstalling the most recent firefox (still no change after that) I noticed that I had an old version. After updating Tampermonkey the link showed up properly.

rjrudman commented 6 years ago

Ah, glad it's working now! What version of Tampermonkey were you using? Just so we can keep track if people have a similar issue in the future? @geisterfurz007

mvarendorff commented 6 years ago

Tampermonkey 4.5.5564 was the version with the issue. Update to now 4.5.5709 resolved.