SOBotics / Higgs

A generic dashboard for viewing and providing feedback to SOBotics bots.
GNU General Public License v3.0
4 stars 0 forks source link

Did I break everything registering feedback types more then 1 time? #29

Closed jdd-software closed 6 years ago

jdd-software commented 6 years ago

I did send first one post request to RegisterFeedbackTypes, since I wanted to update the color of one feedback, I re-send it again (with color changed)

This is the code I used (sending it twice)

RegisterFeedbackTypesRequest rft = new RegisterFeedbackTypesRequest();
FeedbackType fb1 = new FeedbackType();
fb1.setName(FeedBack.TP.toString());
fb1.setColour("green");
fb1.setIcon("✓"); //https://www.fileformat.info/info/unicode/char/2713/index.htm
fb1.setIsActionable(true);
fb1.setRequiredActions(0);
rft.addFeedbackTypesItem(fb1);

FeedbackType fb2 = new FeedbackType();
fb2.setName(FeedBack.FP.toString());
fb2.setColour("red");
fb2.setIcon("❌"); //http://www.fileformat.info/info/unicode/char/274c/index.htm
fb2.setIsActionable(true);
fb2.setRequiredActions(0);
rft.addFeedbackTypesItem(fb2);

FeedbackType fb3 = new FeedbackType();
fb3.setName(FeedBack.FN.toString());
fb3.setColour("orange");
fb3.setIcon("⚠"); //https://www.fileformat.info/info/unicode/char/26a0/index.htm
fb3.setIsActionable(true);
fb3.setRequiredActions(0);
rft.addFeedbackTypesItem(fb3);

FeedbackType fb4 = new FeedbackType();
fb4.setName(FeedBack.NC.toString());
fb4.setColour("yellow");
fb4.setIcon("🗑"); //http://www.fileformat.info/info/unicode/char/1f5d1/index.htm
fb4.setIsActionable(true);
fb4.setRequiredActions(0);
rft.addFeedbackTypesItem(fb4);

FeedbackType fb5 = new FeedbackType();
fb5.setName(FeedBack.SK.toString());
fb5.setColour("gray");
fb5.setIcon("⏩"); //http://www.fileformat.info/info/unicode/char/23e9/index.htm
fb5.setIsActionable(true);
fb5.setRequiredActions(0);
rft.addFeedbackTypesItem(fb5);

botApi.botRegisterFeedbackTypesPost(rft);

After this it's seem like I brook Higgs, server is now responding Internal Server Error, I don't think I have made any other changes to code...

Also note that the icon is not rendered correctly, probably angular is escaping & with &

rjrudman commented 6 years ago

Yes, unfortunately. But you shouldn't have been able to. I've added a webview to properly manage the feedback types, so it won't happen again