search

SOBotics / Redunda

Status monitoring for SOBotics' bots
https://redunda.sobotics.org/
Creative Commons Zero v1.0 Universal
7 stars 5 forks source link

Login via redunda.sobotics.org #18

Closed FelixSFD closed 7 years ago

FelixSFD commented 7 years ago

The login does not work correctly via redunda.sobotics.org. The redirect_uri needs to be changed

ArtOfCode- commented 7 years ago

What does "does not work correctly" mean?

NobodyNada commented 7 years ago

@ArtOfCode- It redirects to redunda.erwaysoftware.com instead of redunda.sobotics.org.

ArtOfCode- commented 7 years ago

Is that really an issue, given that they both serve precisely the same thing, and also that there's no way to make it work so that they each redirect to themselves?

FelixSFD commented 7 years ago

Yes. Because the cookie is set on redunda.erwaysoftware.com. So you can never be logged in on redunda.sobotics.org

Undo1 commented 7 years ago

This is pretty hard to fix. You can only have one OAuth domain, so just changing the redirect_uri isn't going to work. We'd need a central place for cookies, and that's not easy.

j-f1 commented 7 years ago

@Undo1 Why not move to https://redunda.sobotics.org and disable the https://redunda.erwaysoftware.com domain?

Undo1 commented 7 years ago

@j-f1 We went through this with metasmoke too - conclusion was that I'm extremely unlikely to let erwaysoftware.com lapse, since all my email goes through it. We don't have that guarantee with charcoal-se.org or sobotics.org.

It'd be possible, we just need to decide how much uptime and/or the possibility of dead links matters.

FelixSFD commented 7 years ago

redunda.erwaysoftware.com could still be active. But the OAuth domain should be redunda.sobotics.org. So your domain is still the same, but the login only works on .sobotics.org Just like now, but the other way round

Undo1 commented 7 years ago

Done