search

SOCI / soci

Official repository of the SOCI - The C++ Database Access Library
http://soci.sourceforge.net/
Boost Software License 1.0
1.37k stars 472 forks source link

Add support for Network address types for PostgreSQL #1078

Closed Liewyec closed 6 months ago

Liewyec commented 9 months ago

Hello, I noticed a missing support for Network address types for PostgreSQL. I added the support and they are returned s strings.

vadz commented 9 months ago

Sorry, I've somehow missed this. I see no problem with applying this, but I wonder if we should add support for the other related types too, see

https://github.com/postgres/postgres/blob/b6a77c6a6ccf698787201b001cbbbf9c89fe5715/src/include/catalog/pg_type.dat#L256-L265

?

Liewyec commented 8 months ago

Hello, sorry for the late answer, I was a bit busy and sick. I will look into this and add it, it looks easy and unless I am mistaken there are just 2 more types to add. I will update the pull request probably over weekend.

vadz commented 6 months ago

@Liewyec do you still plan to do it? TIA!

Liewyec commented 6 months ago

Hello, yes I am planing to do this, I should have a bit less work in next few weeks. Sorry it takes so long a I had a lot of other work.

Liewyec commented 6 months ago

Hello, I added the two more types, sorry it was taking so long.

vadz commented 6 months ago

Thanks, will merge soon.