search

SOCI / soci

Official repository of the SOCI - The C++ Database Access Library
http://soci.sourceforge.net/
Boost Software License 1.0
1.41k stars 477 forks source link

Make Firebird test reference correct database #1099

Closed Krzmbrzl closed 9 months ago

Krzmbrzl commented 11 months ago

In the CI, a database called soci_test is created https://github.com/SOCI/soci/blob/9bcc5f8a9181886f4c73ea5b4671b35d8722cb3a/scripts/ci/before_build_firebird.sh#L9 but the CMakeLists.txt for the Firebird test encoded a database name of test. Somehow this still worked on the CI, but it didn't work for me locally (invoking ctest directly). Furthermore, using soci_test as the table name makes things more consistent with the tests for other backends.

vadz commented 10 months ago

I really don't understand how did it work before neither, could we be creating test.fdb somewhere else?

Krzmbrzl commented 10 months ago

Maybe the connection string is modified on the CI via some sort of environment variable or something like that?

vadz commented 9 months ago

Thanks for fixing this, finally merged.