search

SOCR / TCIU

Data Science, Time Complexity and Inferential Uncertainty (TCIU)
11 stars 6 forks source link

Issue with upcoming ggplot2 version #3

Open teunbrand opened 1 year ago

teunbrand commented 1 year ago

Hi there,

While preparing for a new release of ggplot2, our reverse dependency check showed that your package's vignette has broken. More specifically, we believe that the vignette can no longer be built due to plots being saved to disk. We generally don't recommend saving plots to disk, partially because the saved objects may contain internal code that is version dependent. ggplot2 tries to keep the exported functions stable, but makes no promise about internal code. In this case, such an internal function has changed (for appealing reasons), but it invalidates plots saved to disk with previous versions of ggplot2.

In particular, we believe that the plots like the ones below have become invalid: https://github.com/SOCR/TCIU/blob/85076ae775a32d89676679cfa6050e683da44d1d/package/TCIU/TCIU/vignettes/tciu-LT-kimesurface.Rmd#L104-L106

If it is very inconvenient to circumvent saving plots to disk, please consider this issue an advance warning. The saved plots might have to be regenerated with the upcoming version of ggplot2. You can test the upcoming changes with the current release candidate, that can be installed with devtools::install_github('tidyverse/ggplot2@v3.4.2-rc').

Best wishes, Teun

teunbrand commented 5 months ago

Hello there,

Once again, we have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break TCIU.

The issue remains the same as the plot above.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. We hope that this issue informs you in a timely manner.

teunbrand commented 5 months ago

This is just a kind reminder that the release of ggplot2 is scheduled soon.