search

SOF3 / await-generator

Write code in async/await style in PHP using generators.
https://sof3.github.io/await-generator/master/
Apache License 2.0
123 stars 15 forks source link

Workflows are referencing vulnerable actions #108

Closed igibek closed 2 years ago

igibek commented 2 years ago

Hello, there!

As part of the university research we are currently doing regarding the security of Github Actions, we noticed that one or many of the workflows that are part of this repository are referencing vulnerable versions of the third-party actions. As part of a disclosure process, we decided to open issues to notify GitHub Community.

Please note that there are could be some false positives in our methodology, thus not all of the open issues could be valid. If that is the case, please let us know, so that we can improve on our approach. You can contact me directly using an email: ikoishy [at] ncsu.edu

Thanks in advance

  1. The workflow ci.yml is referencing action shivammathur/setup-php using references v1. However this reference is missing the commit 7163319 which may contain fix to the vulnerability.
  2. The workflow ci.yml is referencing action shivammathur/setup-php using references v1. However this reference is missing the commit 7163319 which may contain fix to the vulnerability.
  3. The workflow ci.yml is referencing action shivammathur/setup-php using references v1. However this reference is missing the commit 7163319 which may contain fix to the vulnerability.

The vulnerability fix that is missing by actions' versions could be related to: (1) CVE fix (2) upgrade of vulnerable dependency (3) fix to secret leak and others. Please consider updating the reference to the action.

If you end up updating the reference, please let us know. We need the stats for the paper :-)

SOF3 commented 2 years ago

Where's dependabot when it's actually needed...

igibek commented 2 years ago

Hello, there!

It turns out to be a false positive. The aforementioned version v1 actually contains the commit which was cherry-picked to include it, here: 11e062bf. Unfortunately, this commit was missed by our tool.

Sorry for the incorrect reporting.

I am closing this issue because it is safe to use the shivammathur/setup-php@v1 in the workflows.

Have a great day!